Stop running frontend and processor with root user
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulrhmnGhanem
force-pushed
the
no-root-docker
branch
13 times, most recently
from
eec0663 to
e563a9d
Compare
kasbah
reviewed
Oct 25, 2022
kasbah
reviewed
Oct 26, 2022
kasbah
reviewed
Oct 26, 2022
AbdulrhmnGhanem
force-pushed
the
no-root-docker
branch
from
31b8c46 to
84d03ee
Compare
kasbah
reviewed
Oct 27, 2022
kasbah
reviewed
Oct 27, 2022
kasbah
reviewed
Oct 27, 2022
AbdulrhmnGhanem
force-pushed
the
no-root-docker
branch
2 times, most recently
from
85ec6fe to
f49d18d
Compare
kasbah
reviewed
Oct 27, 2022
kasbah
reviewed
Oct 27, 2022
AbdulrhmnGhanem
force-pushed
the
no-root-docker
branch
from
5f2ab8d to
13edb5f
Compare
- We need to install packages, compile ts, and move assets before running the actual testing code. - The `node` user doesn't have permessions to do anything of these tasks. Update scripts/clear_volumes_and_test_processor.sh Co-authored-by: Kaspar Emanuel <[email protected]>
AbdulrhmnGhanem
force-pushed
the
no-root-docker
branch
2 times, most recently
from
aae27cc to
0b61bf6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
kasbah
reviewed
Nov 1, 2022
Co-authored-by: Kaspar Emanuel <[email protected]>
AbdulrhmnGhanem
force-pushed
the
no-root-docker
branch
from
edfa33f to
aaa7f96
Compare
|
Could you resolve the merge conflict with #458 so it will deploy to review.staging please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #450 I noticed the server runs as
rootwhich can lead to some issues.