Fullscreen button #121
Closed
Fullscreen button #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2017 14:33
Browsers implement the fullscreen api in different ways so we use the Fscreen library to handle the fullscreen request. This is the library recommended in the mozilla docs: https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API
We want the button to show up when the mouse is active, so it has to listen to mouse events on the whole body. Seeing how there isn't a place for internal react components and because it is so simple we just use an click listener instead of react.
zorbash
reviewed
Oct 16, 2017
|
|
||
| window.jQuery = window.$ = $; | ||
|
|
||
| Kitto.start(); | ||
|
|
||
| var i = null; |
There was a problem hiding this comment.
application.js is meant for the user to extend / modify appearance and behaviour.
Let's have this in an initializeFullScreenButton function in https://github.com/kittoframework/kitto/blob/master/priv/static/kitto.js also move the fscreen import there.
There was a problem hiding this comment.
Something like the following (haven't tried it):
function initializeFullScreenButton() {
var timer;
var $button = $('.fullscreen-button');
$('body').on('mousemove', function() {
clearTimeout(timer);
if (!$button.hasClass('active')) { $button.addClass('active') }
timer = setTimeout(function() { $button.removeClass('active') }, 1000);
})
$button.on('click', function() {
fscreen.requestFullscreen(document.getElementById('container'));
})
return this;
}which will be called in Kitto.start
zorbash
reviewed
Oct 16, 2017
| @@ -16,6 +16,8 @@ | |||
| <%= @template %> | |||
| </div> | |||
|
|
|||
| <i class="fullscreen-button fa fa-arrows-alt"></i> | |||
There was a problem hiding this comment.
Let's have this before the #container div.
|
Merged! 9d8c391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a button to enable full screen mode. (Closes #19 )
The tiny icon in the top right:
Test it out here!
The fullscreen API is a bit of mess across multiple browsers so it uses the fscreen library to handle the api call. This is the library recommended in the mozilla docs.
Since we want the button to show up when moving the mouse anywhere on the screen it listens to mouse move events on
body. There doesn't seem to be a place for internal react components so while the button could be a component I think it makes more sense to just have the onClick listener.