Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make common stats object #75

Open
matt-raffel-kiva opened this issue Apr 18, 2022 · 0 comments
Open

Make common stats object #75

matt-raffel-kiva opened this issue Apr 18, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@matt-raffel-kiva
Copy link
Collaborator

matt-raffel-kiva commented Apr 18, 2022

Once we stablize the content of the statistics report consumed in our services, we should make this type common and shared.

At this time, the structure is as below but we should be confident this is the final structure before sharing across all services.

export class ServiceReportDto {
    @IsString() serviceName: string;
    @IsString() startedAt: string;
    @IsString() currentTime: string;
    @IsArray() versions: string[];
}

Consider changing versions to resources since this field is intended to be more freeform reporting.

Likewise we might want to add some common functionality around gathering shared statistics of a service. See https://github.com/kiva/protocol-reporting/blob/dc2b99d60f3411cb94e2e68b58da6934956106bd/src/app/app.service.ts#L33 as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant