Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding basic uptime stats #59

Merged
merged 2 commits into from
Apr 18, 2022
Merged

adding basic uptime stats #59

merged 2 commits into from
Apr 18, 2022

Conversation

matt-raffel-kiva
Copy link
Collaborator

Signed-off-by: Matt Raffel [email protected]

Following the same pattern as used in AGA, reporting etc....

Signed-off-by: Matt Raffel <[email protected]>
Signed-off-by: Matt Raffel <[email protected]>
Copy link
Contributor

@natesulat natesulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 what Jeff said, but I don't think it needs to block this PR.

That said, do we have an Issue created for common-izing the DTO?

@matt-raffel-kiva
Copy link
Collaborator Author

+1 what Jeff said, but I don't think it needs to block this PR.

That said, do we have an Issue created for common-izing the DTO?

as I said, I agree. But until we finish unblocking protocol-common, I will not let that cause another feature to be blocked. The issue is written up here: kiva/protocol-common#75

@matt-raffel-kiva matt-raffel-kiva merged commit 3ee1038 into main Apr 18, 2022
@matt-raffel-kiva matt-raffel-kiva deleted the uptime branch April 18, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants