Skip to content

Commit

Permalink
Merge pull request #5072 from kiva/teams_leaderboards_fix
Browse files Browse the repository at this point in the history
fix: text should be shown for all time leaderboard
  • Loading branch information
eddieferrer authored Nov 15, 2023
2 parents c777c7b + 2468c72 commit 2e0f1df
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/pages/LendingTeams/TeamLeaderboard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</h4>
<kv-tabs
class="tw-px-1"
:class="{ 'members-tabs' : showMembersText, 'tw-pb-2' : showMembersText && isLoading }"
:class="{ 'members-tabs' : isNewMembers, 'tw-pb-2' : isNewMembers && isLoading }"
@tab-changed="handleTabChanged"
>
<template #tabNav>
Expand All @@ -39,7 +39,7 @@
</kv-tab>
</template>
<template #tabPanels>
<p v-if="showMembersText" class="tw-text-small tw-my-0.5">
<p v-if="isNewMembers" class="tw-text-small tw-my-0.5">
Only members who have lent at least once are counted
</p>
<kv-tab-panel
Expand Down Expand Up @@ -184,9 +184,6 @@ export default {
return 'Total Amount of Members the Team has';
} return 'Total Amount the Team has lent';
},
showMembersText() {
return this.isNewMembers && [0, 1].includes(this.selectedTabIndex);
}
},
methods: {
determineIfMobile() {
Expand Down

0 comments on commit 2e0f1df

Please sign in to comment.