fix: check completed date when showing badge last tier as completed

kiva · Dec 17, 2024 · 31999da · 31999da
1 parent 0fffe4a
commit 31999da
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/src/components/MyKiva/BadgesSection.vue b/src/components/MyKiva/BadgesSection.vue
@@ -76,7 +76,7 @@ const visibleBadges = computed(() => {
 
 const getBadgeStatus = badge => {
 	const activeTier = getActiveTierData(badge);
-	if (activeTier?.level === badge?.achievementData?.tiers?.length) {
+	if (activeTier?.level === badge?.achievementData?.tiers?.length && activeTier?.completedDate) {
 		return BADGE_COMPLETED;
 	}
 	return BADGE_IN_PROGRESS;

diff --git a/src/composables/useBadgeData.js b/src/composables/useBadgeData.js
@@ -189,17 +189,18 @@ export default function useBadgeData() {
 		const currentTier = badge.achievementData.tiers[levelIndex];
 		/**
 		 * {
-		 *   "id": "",
-		 *   "challengeName": "",
-		 *   "level": 1,
-		 *   "levelName": "",
-		 *   "shareFact": "",
-		 *   "shareFactFootnote": "",
-		 *   "shareFactUrl": "",
-		 *   "imageUrl": "",
-		 *   "target": 1,
-		 *   "tierStatement": "",
-		 *   "learnMoreURL": ""
+		 *   "id": string,
+		 *   "challengeName": string,
+		 *   "level": number,
+		 *   "levelName": string,
+		 *   "shareFact": string,
+		 *   "shareFactFootnote": string,
+		 *   "shareFactUrl": string,
+		 *   "imageUrl": string,
+		 *   "target": number,
+		 *   "tierStatement": string,
+		 *   "learnMoreURL": string,
+		 *   "completedDate": string,
 		 * }
 		 */
 		return {