Skip to content

Commit

Permalink
fix: badges achieved value in events
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian Bedon committed Nov 14, 2024
1 parent 261fb3d commit 7a1bc17
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions src/components/Thanks/MyKiva/ThanksBadges.vue
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
'click',
'create-new-account',
isGuest ? 'guest' : 'signed-in',
numberOfBadgesEarned,
numberOfBadges,
]"
>
{{ continueButtonText }}
Expand Down Expand Up @@ -81,7 +81,7 @@
event-category="post-checkout"
event-label="create-new-account-from-drawer"
event-property="guest"
:event-value="numberOfBadgesEarned"
:event-value="numberOfBadges"
/>
</div>
</KvExpandable>
Expand Down Expand Up @@ -146,7 +146,7 @@
<GuestAccountCreation
event-label="create-new-account"
event-property="guest"
:event-value="numberOfBadgesEarned"
:event-value="numberOfBadges"
/>
</KvLightbox>
</div>
Expand Down Expand Up @@ -199,10 +199,6 @@ const props = defineProps({
type: Object,
default: () => ({}),
},
numberOfBadgesEarned: {
type: Number,
default: 0
}
});
const { getHighestPriorityDisplayBadge, getLastCompletedBadgeLevelData } = useBadgeData();
Expand Down Expand Up @@ -256,7 +252,7 @@ const handleContinue = () => {
'click',
'open-account-creation-drawer',
'guest',
props.numberOfBadgesEarned,
numberOfBadges.value,
);
} else {
const hasBadges = numberOfBadges.value > 0;
Expand All @@ -266,7 +262,7 @@ const handleContinue = () => {
'click',
'continue-to-my-kiva',
'guest',
props.numberOfBadgesEarned,
numberOfBadges.value,
);
// eslint-disable-next-line vue/no-mutating-props
Expand All @@ -280,7 +276,7 @@ const handleClickCreateAccount = () => {
'click',
'open-account-creation-drawer',
'guest',
props.numberOfBadgesEarned,
numberOfBadges.value,
);
openCreateAccount.value = !openCreateAccount.value;
Expand All @@ -292,7 +288,7 @@ const handleClickOrderConfirmation = () => {
'click',
'open-order-confirmation-drawer',
props.isGuest ? 'guest' : 'signed-in',
props.numberOfBadgesEarned,
numberOfBadges.value,
);
openOrderConfirmation.value = !openOrderConfirmation.value;
Expand Down

0 comments on commit 7a1bc17

Please sign in to comment.