fix: badges loading indicator

kiva · Nov 25, 2024 · e2414fb · e2414fb
1 parent cbced40
commit e2414fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/src/pages/Portfolio/LendingStats/BadgesSection.vue b/src/pages/Portfolio/LendingStats/BadgesSection.vue
@@ -38,10 +38,9 @@ export default {
 			type: Array,
 			default: () => []
 		},
-		/* total number of possible badges */
-		totalPossibleBadges: {
-			type: Number,
-			default: 0
+		isLoading: {
+			type: Boolean,
+			default: false
 		},
 	},
 	components: {
@@ -52,9 +51,6 @@ export default {
 		badgesObtained() {
 			return this.completedAchievements.length ?? 0;
 		},
-		isLoading() {
-			return this.totalPossibleBadges === 0;
-		},
 	},
 };
 </script>
diff --git a/src/pages/Portfolio/LendingStats/LendingStatsPage.vue b/src/pages/Portfolio/LendingStats/LendingStatsPage.vue
@@ -23,7 +23,7 @@
 					</p>
 					<hr class="tw-border-tertiary tw-my-4">
 					<badges-section
-						:total-possible-badges="totalPossibleBadges"
+						:is-loading="badgesLoading"
 						:completed-achievements="completedAchievements"
 					/>
 					<hr class="tw-border-tertiary tw-my-4">
@@ -178,10 +178,8 @@ export default {
 
 			return completedBadgesArr;
 		},
-		totalPossibleBadges() {
-			return this.badgesData.reduce((acc, badge) => {
-				return acc + (badge?.contentfulData?.length ?? 0);
-			}, 0);
+		badgesLoading() {
+			return !this.badgesData.length;
 		}
 	},
 	methods: {