Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure all assets get compressed before upload MARS-288 #4964

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix: ensure all assets get compressed before upload MARS-288 #4964

merged 1 commit into from
Sep 14, 2023

Conversation

emuvente
Copy link
Collaborator

Gzip version of some files was not being generated, which caused a 403/404 when trying to request them.

I discovered this in the description of the minRatio option:

Use a value of Infinity to process all assets even if they are larger than the original size or their original size is 0 bytes (useful when you are pre-zipping all assets for AWS).

@emuvente emuvente requested review from christian14b and a team September 14, 2023 02:34
@emuvente emuvente merged commit df1e65f into main Sep 14, 2023
1 check passed
@emuvente emuvente deleted the compress-all-assets branch September 14, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyersituations dyersituations dyersituations approved these changes

@mcstover mcstover mcstover approved these changes

@christian14b christian14b Awaiting requested review from christian14b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emuvente @mcstover @dyersituations