Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out unhanded google ads code request errors from sentry #4965

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix: filter out unhanded google ads code request errors from sentry #4965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba925ac
fix: filter out unhanded google ads code request errors from sentry
mcstover Sep 14, 2023
d8337bd
fix: check secondary string in google topics realated api failure
mcstover Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ export default function createApp({
// make sentry colleted event easy to compare to
const eventAsString = JSON.stringify(event);
// match specific 3rd party events for exclusion
// Skip sending failed to fetch error caused by unhandled promise rejection in google ads
// Sentry Event Link: https://kiva.sentry.io/issues/4413252219/events/726c65f507684f43b748e913d4793518/
// This url is unreachable: https://pagead2.googlesyndication.com/pagead/buyside_topics/set/
if (eventAsString.indexOf('Failed to fetch') !== -1
&& eventAsString.indexOf('pagead') !== -1) {
return false;
}
// Skip sending failed loads of pX
// eslint-disable-next-line quotes
if (eventAsString.indexOf("Cannot set property 'PX1065' of undefined") !== -1) {
Expand Down
Loading