Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update lending insights module #4973

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

christian14b
Copy link
Collaborator

  • Add “Loans made” stat from Account Overview
  • Remove “Loans by your invitees”
image

@christian14b christian14b requested a review from a team September 19, 2023 21:56
</div>
<div class="tw-col-span-12 md:tw-col-span-6">
<kv-loading-placeholder v-if="loading" class="stat-placeholder" style="width: 10rem;" />
<kv-grid as="dl" class="tw-grid-cols-12 tw-p-1.5 tw-rounded" :style="{backgroundColor: '#FFFFFF0D'}">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have a close color in our pre-defined colors?

@@ -148,16 +160,21 @@ export default {

<style lang="postcss" scoped>
.stat-placeholder {
margin: 0 auto;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replaced with tw-my-0 tw-mx-auto

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or some similar combination, since I see this section applies other margin CSS.

@christian14b christian14b merged commit 17126b8 into main Sep 20, 2023
1 check passed
@christian14b christian14b deleted the update-lending-insights-MARS-500 branch September 20, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants