feat: prevent loading state while waiting for the post #5012
Conversation
|
@christian14b Both this PR and https://github.com/kiva/cms-page-server/pull/693 seem related, and the recent changes seem good. Were you able to test locally? If so, I can approve, I just know we had issues with testing the previous iteration of the promo spot. |
Yeah! they both work well locally, this work is related to the existing blog post so they're not completely related, just happens that the timing was really close |
| } | ||
| }, | ||
| created() { |
There was a problem hiding this comment.
Let's use mounted instead so that this isn't started on the server-side. The server completes the request as soon as created finishes, so anything async started during that is ignored.
There was a problem hiding this comment.
I'll create a quick pr for this. Thanks!
In the past implementation, the module was still appearing while fetching the post and then disappeared if no posts were found.
With this implementation the page will decide to show or not the whole education module, instead of the module.
The downside of this is that we will have to make an api call even if the module is not visible.