Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: turn off apollo batching for ui in all evns including prod #5056

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: turn off apollo batching for ui in all evns including prod #5056

merged 1 commit into from
Nov 9, 2023

Conversation

mcstover
Copy link
Collaborator

@mcstover mcstover commented Nov 1, 2023

Preparation for changes to api infra

@mcstover mcstover requested review from a team November 1, 2023 18:46
@kathrynlovett
Copy link
Contributor

Does this need to be updated for the EKS side as well? It uses the dynamic config: https://github.com/kiva/ui/blob/main/config/dynamic.js#L3

@mcstover
Copy link
Collaborator Author

mcstover commented Nov 1, 2023

Does this need to be updated for the EKS side as well? It uses the dynamic config: https://github.com/kiva/ui/blob/main/config/dynamic.js#L3

i don't think dynamic config needs to change. We are passing in false via flux for the envs that use that and batching is already off there. I'll double check the prod config for ui in flux though!

kathrynlovett
kathrynlovett approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@kathrynlovett kathrynlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mcstover
Copy link
Collaborator Author

mcstover commented Nov 9, 2023

@emuvente I think we need to go ahead with this update, please review.

emuvente
emuvente approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@emuvente emuvente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@mcstover mcstover merged commit 11a35cc into main Nov 9, 2023
4 checks passed
@mcstover mcstover deleted the turn-off-apollo-batching branch November 9, 2023 22:42
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.720.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.720.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeTravisKiva JoeTravisKiva JoeTravisKiva approved these changes

@kathrynlovett kathrynlovett kathrynlovett approved these changes

@dyersituations dyersituations dyersituations approved these changes

@emuvente emuvente emuvente approved these changes

Assignees
No one assigned
Labels
released on @staging released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcstover @kathrynlovett @kiva-robot @emuvente @dyersituations @JoeTravisKiva