Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce checkout query complexity #5060

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

mcstover
Copy link
Collaborator

@mcstover mcstover commented Nov 6, 2023

  • Move the new ftd settings to a different query
  • Add Sentry log for missing totals data. One key component of critical basket data.
    • Looks like our current apollo prefetch handler is not returning the errors out of the collected set of queries so a check at that level will need additional work.

Copy link
Collaborator

@roger-in-kiva roger-in-kiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@roger-in-kiva
Copy link
Collaborator

Should be nice to find a way to replicate the query complexity error in dev to prevent it in prod.

@mcstover mcstover changed the title Fix reduce checkout query complexity fix: reduce checkout query complexity Nov 6, 2023
Copy link
Contributor

@JoeTravisKiva JoeTravisKiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems like we finally found a benefit of using Apollo Router.

@mcstover mcstover merged commit 04af76d into main Nov 6, 2023
4 of 5 checks passed
@mcstover mcstover deleted the fix-reduce-checkout-query-complexity branch November 6, 2023 20:50
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.719.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants