feat: run release and release build in same workflow #5062
Conversation
| uses: ./.github/actions/semantic-release | ||
| env: | ||
| GITHUB_PAT: ${{ secrets.KIVA_ROBOT_GITHUB_PAT }} | ||
| with: | ||
| config: "node" | ||
|
|
||
| # Build and push the image to ECR if the release was published | ||
| build-image: |
There was a problem hiding this comment.
Can most of this code move back into the gh-actions repo at some point for easier reuse?
There was a problem hiding this comment.
Yeah, gha allows for reusable/shareable workflows. I think it would be great if we could eventually setup these workflows in the github actions repo and then reference them in all the app repos.
There was a problem hiding this comment.
This all looks great to me! Left a couple questions but nothing blocking. Do we want to update the release-build action at all to prevent builds on tag pushes, now that we're building in the semantic release action?
@kathrynlovett Sorry I missed this at first. Yes, we should update that too, thanks for catching that! I just pushed up a commit to do that. |
|
🎉 This PR is included in version 2.720.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.720.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.720.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.