Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: goals service notify me in thanks page ack 864 #5115

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

christian14b
Copy link
Collaborator

New "Notify me" component within the standard thanks page that allows user to be added to an iterable list. To choose which team's goal to display (in the edge case a person belongs to two teams and make checkout to two different challenges) it'll select the team assigned to the last loan.

Mail icon will change in the future

Screenshot 2024-01-08 at 15 29 10

@christian14b christian14b requested review from emuvente and a team January 8, 2024 22:56
@christian14b christian14b changed the title Goals service notify me in thanks page ack 864 feat: goals service notify me in thanks page ack 864 Jan 9, 2024
totalCount
values {
lender {
id
image {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tabbing should be fixed in this file.

@dyersituations
Copy link
Collaborator

@christian14b Approved pending issue found in tests regarding formatting in NotifyMe.vue. See in the console of the Ui Tests action.

@christian14b christian14b merged commit d67afa5 into main Jan 9, 2024
5 checks passed
@christian14b christian14b deleted the goals-service-notify-me-in-thanks-page-ACK-864 branch January 9, 2024 02:18
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.724.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 2.724.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants