feat: add global tracing for express + graphql, include trace and spa… #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n ids in winston logs
mcstover
commented
Jan 10, 2024
hobbsh
reviewed
Jan 10, 2024
hobbsh
reviewed
Jan 10, 2024
hobbsh
reviewed
Jan 10, 2024
| // attributes are helpful if we want to inspect and omit requests such as health checks or timesync | ||
| // eslint-disable-next-line no-unused-vars | ||
| function ignoreTheseSpans(spanName, spanKind, attributes) { | ||
| return spanKind !== opentelemetry.SpanKind.SERVER; |
There was a problem hiding this comment.
Are we sure SERVER spans should be excluded?
There was a problem hiding this comment.
This is right from there example for express so maybe... Ultimately, I had problems getting the filter function to work on broader excludes so I trimmed it back down to what they had in their examples.
dyersituations
approved these changes
Jan 17, 2024
|
🎉 This PR is included in version 2.734.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.734.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n ids in winston logs
Couples with: https://github.com/kiva/flux/pull/607