Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll to on page load on sections with async data #5680

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat: scroll to on page load on sections with async data #5680

merged 3 commits into from
Nov 13, 2024

Conversation

dyersituations
Copy link
Collaborator

https://kiva.atlassian.net/browse/MP-1041

  • We want to scroll to two different MyKiva sections when continuing from the TY page
  • Data is loaded async, so we needed a way to wait for that data
  • This implements the logged-in use case, there's another ticket for the guest use case

@dyersituations dyersituations merged commit 01a8cee into main Nov 13, 2024
5 checks passed
@dyersituations dyersituations deleted the MP-1041-fe-scroll-to-on-page-load-on-sections-with-async-data branch November 13, 2024 18:38
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.4.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger-in-kiva roger-in-kiva roger-in-kiva approved these changes

@christian14b christian14b christian14b approved these changes

Assignees
No one assigned
Labels
released on @staging released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyersituations @kiva-robot @christian14b @roger-in-kiva