feat: filter loans in carousel by status #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian14b
requested review from
emuvente,
dyersituations and
roger-in-kiva
|
With a 10 limit in the query for these loans, are we ensuring that w'ell have 9 after filtering? |
We probably need to increase that limit |
Agreed, how much data is pulled back on each loan? If it's minimal, and the query is just used on MyKiva, increasing to 50 might be OK. |
emuvente
approved these changes
Nov 19, 2024
dyersituations
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version 3.4.0-rc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter loans which status are different from:
FUNDED,FUNDRAISING,PAYING_BACK,RAISED