feat: level added to badge tile #5702

roger-in-kiva · 2024-11-20T17:16:28Z

src/components/MyKiva/BadgeTile.vue

emuvente · 2024-11-20T23:29:58Z

src/components/MyKiva/BadgeTile.vue

@@ -104,11 +104,14 @@ const selectedTier = computed(() => {
 	const tiers = [];
 	tieredBadges.value.forEach(badge => {
 		const tier = badge.achievementData?.tiers?.find(t => !t.completedDate);
+		const tierBadgeData = getTierBadgeDataByLevel(badge, tier.level);


@roger-in-kiva I'm currently seeing an error in development that I think is from this line:

TypeError: Cannot read properties of undefined (reading 'level') at ImpactDashboardPage-…Ew0aJ_.js:362:30356 at Array.forEach (<anonymous>) at ImpactDashboardPage-…Ew0aJ_.js:362:30226 at Zr.fn (main-8VcMS5f5.js:10:9412) at Zr.run (main-8VcMS5f5.js:10:1517) at get value (main-8VcMS5f5.js:10:9657) at HT (main-8VcMS5f5.js:10:1674) at get dirty (main-8VcMS5f5.js:10:1236) at y (main-8VcMS5f5.js:14:12520) at cp (main-8VcMS5f5.js:14:2693) at ne (main-8VcMS5f5.js:14:42805) at Zr.q [as fn] (main-8VcMS5f5.js:14:41794) at Zr.run (main-8VcMS5f5.js:10:1517) at G.w.update (main-8VcMS5f5.js:14:42660) at ie (main-8VcMS5f5.js:14:41531) at D (main-8VcMS5f5.js:14:41171) at p (main-8VcMS5f5.js:14:38057) at C (main-8VcMS5f5.js:14:40413) at x (main-8VcMS5f5.js:14:40961) at p (main-8VcMS5f5.js:14:37991) at C (main-8VcMS5f5.js:14:40413) at x (main-8VcMS5f5.js:14:40961) at p (main-8VcMS5f5.js:14:37991) at C (main-8VcMS5f5.js:14:40413) at I (main-8VcMS5f5.js:14:39760) at _ (main-8VcMS5f5.js:14:38656) at p (main-8VcMS5f5.js:14:38031) at Zr.q [as fn] (main-8VcMS5f5.js:14:41929) at Zr.run (main-8VcMS5f5.js:10:1517) at G.w.update (main-8VcMS5f5.js:14:42660) at An (main-8VcMS5f5.js:14:1381) at Ty (main-8VcMS5f5.js:14:3112)

## [3.5.0-rc.1](v3.4.0...v3.5.0-rc.1) (2024-12-09) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6))

## [3.5.0-rc.1](v3.4.0...v3.5.0-rc.1) (2024-12-10) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6))

## [3.6.0-rc.1](v3.5.0...v3.6.0-rc.1) (2024-12-10) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * merge down production branch, cleanup merge conflicts from hotfix merge failure ([9853bad](9853bad)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6)) * sync package + package lock kv-tokens version ([4b058e7](4b058e7))

kiva-robot · 2024-12-10T01:51:08Z

🎉 This PR is included in version 3.6.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [3.6.0](v3.5.0...v3.6.0) (2024-12-10) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * merge down production branch, cleanup merge conflicts from hotfix merge failure ([9853bad](9853bad)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6)) * **release:** 3.6.0-rc.1 [skip ci] ([69061b2](69061b2)), closes [#5712](#5712) [#5708](#5708) [#5702](#5702) [#5706](#5706) [#5719](#5719) [#5705](#5705) [#5720](#5720) [#5718](#5718) * sync package + package lock kv-tokens version ([4b058e7](4b058e7))

kiva-robot · 2024-12-10T18:04:48Z

🎉 This PR is included in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat: level added to badge tile

d06e8ea

roger-in-kiva requested a review from dyersituations November 20, 2024 17:16

dyersituations reviewed Nov 20, 2024

View reviewed changes

src/components/MyKiva/BadgeTile.vue Outdated Show resolved Hide resolved

fix: level replaced with level name

5021fa6

dyersituations approved these changes Nov 20, 2024

View reviewed changes

roger-in-kiva merged commit 07166ba into main Nov 20, 2024
5 checks passed

roger-in-kiva deleted the MP-1100_badge_tile_level_fix branch November 20, 2024 18:34

emuvente reviewed Nov 20, 2024

View reviewed changes

kiva-robot added the released on @staging label Dec 10, 2024

kiva-robot added the released label Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: level added to badge tile #5702

feat: level added to badge tile #5702

roger-in-kiva commented Nov 20, 2024

emuvente Nov 20, 2024

kiva-robot commented Dec 10, 2024

kiva-robot commented Dec 10, 2024

feat: level added to badge tile #5702

feat: level added to badge tile #5702

Conversation

roger-in-kiva commented Nov 20, 2024

emuvente Nov 20, 2024

Choose a reason for hiding this comment

kiva-robot commented Dec 10, 2024

kiva-robot commented Dec 10, 2024