fix: badge tile bug fixed #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roger-in-kiva
force-pushed
the
MP-1100_badge_tile_title_fix
branch
from
620a5a6 to
9c8cf80
Compare
emuvente
approved these changes
Nov 21, 2024
dyersituations
approved these changes
Nov 21, 2024
kiva-robot
added a commit
that referenced
this pull request
Dec 9, 2024
## [3.5.0-rc.1](v3.4.0...v3.5.0-rc.1) (2024-12-09) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6))
kiva-robot
added a commit
that referenced
this pull request
Dec 10, 2024
## [3.5.0-rc.1](v3.4.0...v3.5.0-rc.1) (2024-12-10) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6))
kiva-robot
added a commit
that referenced
this pull request
Dec 10, 2024
## [3.5.0-rc.1](v3.4.0...v3.5.0-rc.1) (2024-12-10) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6))
kiva-robot
added a commit
that referenced
this pull request
Dec 10, 2024
## [3.6.0-rc.1](v3.5.0...v3.6.0-rc.1) (2024-12-10) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * merge down production branch, cleanup merge conflicts from hotfix merge failure ([9853bad](9853bad)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6)) * sync package + package lock kv-tokens version ([4b058e7](4b058e7))
|
🎉 This PR is included in version 3.6.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiva-robot
added a commit
that referenced
this pull request
Dec 10, 2024
## [3.6.0](v3.5.0...v3.6.0) (2024-12-10) ### 🎉 New Features * add ecosystem themes ([9cb391e](9cb391e)) * add more to badge title caption ([124c6d0](124c6d0)) * add tiered badges to BadgesList component ([2c29b71](2c29b71)) * bp activity fead code clean up ([#5712](#5712)) ([4217368](4217368)) * complete status added to journey ([#5708](#5708)) ([7dad329](7dad329)) * connect MyKiva TY page to real achievement service data ([2a09064](2a09064)) * firing hotjar event in my kiva page ([3d16a87](3d16a87)) * hide badge tile when all tiered badges are completed ([5a10410](5a10410)) * implement logic for when to show MyKiva view of thanks page ([03981d8](03981d8)) * level added to badge tile ([#5702](#5702)) ([07166ba](07166ba)) * load more updates ([#5706](#5706)) ([7c6277c](7c6277c)) * logic for displaying MyKiva minus checking achieved badge and opt out ([1a2db15](1a2db15)) * remove totalPossibleBadges from start of badges section ([36e8e0f](36e8e0f)) * ty page badge animations ([#5719](#5719)) ([611c298](611c298)) ### 🐛 Bugfixes * add clarifying comment ([d4e9dad](d4e9dad)) * add missing stories for MyKiva badge modal ([55f568a](55f568a)) * add MyKiva TY view and correct props, but not currently shown ([51ec31c](51ec31c)) * add one more optional chaining ([20ad09c](20ad09c)) * added missing MyKiva TY page analytics ([ee25ccf](ee25ccf)) * adding publicId param to jsdoc ([233535f](233535f)) * adjustments for guest user in MyKiva TY flow ([ea4ae6c](ea4ae6c)) * badge tile bug fixed ([#5705](#5705)) ([f1c03ce](f1c03ce)) * badges loading indicator ([e2414fb](e2414fb)) * basket link z-index in sticky checkout exp ([12b872c](12b872c)) * change event handler to transition ([779b1e0](779b1e0)) * climate action needed one more tag filter ([622edd4](622edd4)) * don't how badges without new tier achieved, only show MyKiva TY when loans checked out ([32c8b3c](32c8b3c)) * enhance image quality ([c795c3e](c795c3e)) * get the correct completed tier, handle when tiers completed at the same time ([7d05a89](7d05a89)) * improve print view of MyKiva TY page ([1c4e19f](1c4e19f)) * link styles for personalized lend menu ([2ba6d39](2ba6d39)) * merge down production branch, cleanup merge conflicts from hotfix merge failure ([9853bad](9853bad)) * minor style fixes for SystemPage frame and Settings page ([f0c7240](f0c7240)) * missing optional chaining ([90517bf](90517bf)) * missing optional chaining ([801799f](801799f)) * mykiva hero images replaced ([#5720](#5720)) ([6584a07](6584a07)) * only show badges module when badges achieved or guest, don't show rays on loading ([4fb6ae9](4fb6ae9)) * remove totalPossibleBadges prop ([cbced40](cbced40)) * remove underline from promo banner ([7338105](7338105)) * remove underline from tertiary and secondary menus ([dae4906](dae4906)) * remove underlines from header nav links ([921f0c9](921f0c9)) * removed unneeded prop from opt in module ([afaab6c](afaab6c)) * removed unused import ([9caa36c](9caa36c)) * resolve comments and total possible badges count ([112cfa0](112cfa0)) * resolve issue where equality badge wasn't being shown ([aab297a](aab297a)) * resolve issue with guest use case ([56590d4](56590d4)) * resolve warning about stat prop ([aaafa25](aaafa25)) * revert code for experiment ACK-469 ([2d5dacf](2d5dacf)) * solve conflict ([f1aa2cc](f1aa2cc)) * support case where user has not opted in and didn't achieve a badge ([c24beb9](c24beb9)) * tracking event trigger fixed for loans number ([#5718](#5718)) ([953c8ec](953c8ec)) * update header and footer styling for ecosystem default theme MP-1103 ([49060e5](49060e5)) * update kv-components location ([c106daa](c106daa)) * use alias for kv-components imports ([1f031c5](1f031c5)) ### 💅 Code Style Changes * fix lint whitespace error ([d09d825](d09d825)) ### 🧹 Chores * add request/response metadata to logs ([6aebdf0](6aebdf0)) * **deps:** upgrade kv-components and kv-shop ([7d289db](7d289db)) * **deps:** upgrade kv-components, kv-shop, and kv-tokens to latest ([a5df3d6](a5df3d6)) * **release:** 3.6.0-rc.1 [skip ci] ([69061b2](69061b2)), closes [#5712](#5712) [#5708](#5708) [#5702](#5702) [#5706](#5706) [#5719](#5719) [#5705](#5705) [#5720](#5720) [#5718](#5718) * sync package + package lock kv-tokens version ([4b058e7](4b058e7))
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks catching this @emuvente