Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track lines in journey and removing unused stories #5734

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: track lines in journey and removing unused stories #5734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
114ffb0
fix: track lines in journey and removing unused stories
Dec 12, 2024
7edc443
fix: hide overflow when shine is enable
Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .storybook/stories/BadgeContainer.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,5 @@ export const RectangleInProgress = story({ status: BADGE_IN_PROGRESS, shape: BAD

export const RectangleLocked = story({ status: BADGE_LOCKED, shape: BADGE_SHAPE_RECTANGLE }, badgeUsEconomicEquality.contentfulData[0].imageUrl);

export const BadgeWithRays = story({showRays: true, status: BADGE_COMPLETED, shape: BADGE_SHAPE_ARCH}, badgeClimateAction.contentfulData[0].imageUrl);

export const BadgeWithShine = story({showShine: true, status: BADGE_COMPLETED, shape: BADGE_SHAPE_ARCH}, badgeClimateAction.contentfulData[0].imageUrl);

export const BadgeWithShineAndRays = story({showRays: true, showShine: true, status: BADGE_COMPLETED, shape: BADGE_SHAPE_ARCH}, badgeClimateAction.contentfulData[0].imageUrl);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these no longer applicable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.. seems like rays have being moved from this component

3 changes: 2 additions & 1 deletion src/components/MyKiva/BadgeContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<template>
<div
class="tw-relative tw-inline-block tw-w-auto tw-overflow-hidden"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tw-overflow-hidden is already used in TY page, can we add a prop for that case?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's used for shining effect, probably should be added under that condition...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by that? do you use it in ty page? I don't see anything changed in the ty pages stories.. could you take a look ?

Copy link
Collaborator

@roger-in-kiva roger-in-kiva Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fixed for all cases we have.

Is this case no longer available? I don't see the story we had...
Screenshot 2024-12-12 at 2 49 54 p m

class="tw-relative tw-inline-block tw-w-auto"
:class="{
'tw-grayscale': isInProgress,
'invisible-badge tw-cursor-pointer': isLocked,
'tw-overflow-hidden': showShine,
}"
@click="handleBadgeClick"
>
Expand Down
Loading