Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate recommended loans endpoint with lending home row #5738

Merged
merged 6 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/graphql/query/loanRecommendationsExtendedQuery.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#import '../fragments/loanCardFieldsExtended.graphql'

query loanRecommendations(
$filterObject: [FundraisingLoanSearchFilterInput!]
$sortBy: SortEnum = personalized
$imgDefaultSize: String = "w480h360"
$imgRetinaSize: String = "w960h720"
$origin: String
$userId: Int
$limit: Int
) {
loanRecommendations(
filters: $filterObject,
sortBy: $sortBy,
origin: $origin,
userId: $userId,
limit: $limit
) {
totalCount
values {
id
...loanCardFieldsExtended
image {
id
hash
default: url(customSize: $imgDefaultSize)
retina: url(customSize: $imgRetinaSize)
}
}
}
}
31 changes: 31 additions & 0 deletions src/graphql/query/loanRecommendationsQuery.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#import '../fragments/loanCardFields.graphql'

query loanRecommendations(
$filterObject: [FundraisingLoanSearchFilterInput!]
$sortBy: SortEnum = personalized
$imgDefaultSize: String = "w480h360"
$imgRetinaSize: String = "w960h720"
$origin: String
$userId: Int
$limit: Int
) {
loanRecommendations(
filters: $filterObject,
sortBy: $sortBy,
origin: $origin,
userId: $userId,
limit: $limit
) {
totalCount
values {
id
...loanCardFields
image {
id
default: url(customSize: $imgDefaultSize)
retina: url(customSize: $imgRetinaSize)
hash
}
}
}
}
113 changes: 88 additions & 25 deletions src/pages/LoanFinding/LoanFinding.vue
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,13 @@ import LendingCategorySection from '#src/components/LoanFinding/LendingCategoryS
import QuickFiltersSection from '#src/components/LoanFinding/QuickFiltersSection';
import PartnerSpotlightSection from '#src/components/LoanFinding/PartnerSpotlightSection';
import FiveDollarsBanner from '#src/components/LoanFinding/FiveDollarsBanner';
import { runLoansQuery } from '#src/util/loanSearch/dataUtils';
import { runLoansQuery, runRecommendationsQuery } from '#src/util/loanSearch/dataUtils';
import { FLSS_ORIGIN_LEND_BY_CATEGORY } from '#src/util/flssUtils';
import { createIntersectionObserver } from '#src/util/observerUtils';
import { trackExperimentVersion } from '#src/util/experiment/experimentUtils';
import { spotlightData } from '#src/assets/data/components/LoanFinding/spotlightData.json';
import flssLoansQueryExtended from '#src/graphql/query/flssLoansQueryExtended.graphql';
import loanRecommendationsQueryExtended from '#src/graphql/query/loanRecommendationsExtendedQuery.graphql';
import retryAfterExpiredBasket from '#src/plugins/retry-after-expired-basket-mixin';
import fiveDollarsTest, { FIVE_DOLLARS_NOTES_EXP } from '#src/plugins/five-dollars-test-mixin';
import hugeLendAmount from '#src/plugins/huge-lend-amount-mixin';
Expand All @@ -132,12 +133,23 @@ import HandOrangeIcon from '#src/assets/images/hand_orange.svg';
import basketModalMixin from '#src/plugins/basket-modal-mixin';
import KvCartModal from '#kv-components/KvCartModal';

const prefetchedRecommendedLoansVariables = { pageLimit: 4, origin: FLSS_ORIGIN_LEND_BY_CATEGORY };
const prefetchedFlssVariables = {
pageLimit: 4,
origin: FLSS_ORIGIN_LEND_BY_CATEGORY
};

const prefetchedRecommendationsVariables = {
origin: FLSS_ORIGIN_LEND_BY_CATEGORY,
dyersituations marked this conversation as resolved.
Show resolved Hide resolved
userId: null,
limit: 4
};

const FLSS_ONGOING_EXP_KEY = 'EXP-FLSS-Ongoing-Sitewide-3';
const THREE_LOANS_RECOMMENDED_ROW_EXP_KEY = 'lh_three_loans_recommended_row';
const FIVE_DOLLARS_BANNER_KEY = 'kvfivedollarsbanner';
const QUICK_FILTERS_MOBILE_EXP_KEY = 'lh_qf_mobile_version';
const ALMOST_FUNDED_ROW_EXP_KEY = 'lh_almost_funded_row';
const LOAN_RECOMMENDATIONS_EXP_KEY = 'lh_loan_recommendations';

export default {
name: 'LoanFinding',
Expand Down Expand Up @@ -181,26 +193,44 @@ export default {
enableQFMobileVersion: false,
enableAlmostFundedRow: false,
HandOrangeIcon,
enableLoanRecommendations: false,
};
},
apollo: {
preFetch(config, client) {
return client.query({
query: experimentAssignmentQuery, variables: { id: THREE_LOANS_RECOMMENDED_ROW_EXP_KEY }
}).then(() => {
const recommendedLoansPromise = client.query({
query: flssLoansQueryExtended,
variables: prefetchedRecommendedLoansVariables
});
return Promise.all([
client.query({
query: experimentAssignmentQuery,
variables: { id: LOAN_RECOMMENDATIONS_EXP_KEY }
}),
client.query({ query: userInfoQuery })
]).then(([recommendationsExp, userInfo]) => {
const useRecommendations = recommendationsExp?.data?.experiment?.version === 'b';
const userId = userInfo?.data?.my?.userAccount?.id || null;

return Promise.all([
client.query({ query: userInfoQuery }),
client.query({ query: experimentAssignmentQuery, variables: { id: FIVE_DOLLARS_NOTES_EXP } }),
client.query({ query: experimentAssignmentQuery, variables: { id: FLSS_ONGOING_EXP_KEY } }),
recommendedLoansPromise
client.query({
query: experimentAssignmentQuery,
variables: { id: THREE_LOANS_RECOMMENDED_ROW_EXP_KEY }
}),
client.query({
query: experimentAssignmentQuery,
variables: { id: FIVE_DOLLARS_NOTES_EXP }
}),
client.query({
query: experimentAssignmentQuery,
variables: { id: FLSS_ONGOING_EXP_KEY }
}),
client.query({
query: useRecommendations ? loanRecommendationsQueryExtended : flssLoansQueryExtended,
variables: useRecommendations ? {
...prefetchedRecommendationsVariables,
userId
} : prefetchedFlssVariables
})
]);
});
},
}
},
computed: {
isLoggedIn() {
Expand Down Expand Up @@ -262,22 +292,31 @@ export default {
},
methods: {
async getRecommendedLoans() {
const { loans } = await runLoansQuery(
this.apollo,
{ pageLimit: 12 },
FLSS_ORIGIN_LEND_BY_CATEGORY
);
let loans = [];
if (this.enableLoanRecommendations) {
const response = await runRecommendationsQuery(this.apollo, {
userId: this.userInfo?.id || null,
michelleinez marked this conversation as resolved.
Show resolved Hide resolved
origin: FLSS_ORIGIN_LEND_BY_CATEGORY,
limit: 12
});
loans = response.loans;
} else {
const response = await runLoansQuery(
this.apollo,
{ pageLimit: 12 },
FLSS_ORIGIN_LEND_BY_CATEGORY
);
loans = response.loans;
}

// Ensure unique loans are pushed since recommendations can change quickly
const remainingRecommendedLoans = loans
.filter(l => !this.firstRowLoans.filter(r => r.id === l.id).length)
.slice(0, 8);

this.firstRowLoans = [
...this.firstRowLoans.slice(0, 4),
...remainingRecommendedLoans
];

this.trackFirstRowDisplayedLoans();
},
async getSecondCategoryData() {
Expand Down Expand Up @@ -424,16 +463,40 @@ export default {
}
},
created() {
const loanRecommendationsData = trackExperimentVersion(
this.apollo,
this.$kvTrackEvent,
'Lending',
LOAN_RECOMMENDATIONS_EXP_KEY,
'EXP-DSCI-2167-Dec2024'
);

this.enableLoanRecommendations = loanRecommendationsData.version === 'b';

const cachedUserInfo = this.apollo.readQuery({
query: userInfoQuery,
});

this.userInfo = cachedUserInfo.my?.userAccount ?? {};

const cachedRecommendedLoans = this.apollo.readQuery({
query: flssLoansQueryExtended,
variables: prefetchedRecommendedLoansVariables
})?.fundraisingLoans?.values?.filter(loan => loan !== null) ?? [];
let cachedRecommendedLoans = [];
if (this.enableLoanRecommendations) {
const recommendedLoansData = this.apollo.readQuery({
query: loanRecommendationsQueryExtended,
variables: {
...prefetchedRecommendationsVariables,
userId: this.userInfo?.id || null
michelleinez marked this conversation as resolved.
Show resolved Hide resolved
}
});
cachedRecommendedLoans = recommendedLoansData
?.loanRecommendations?.values?.filter(loan => loan !== null) ?? [];
} else {
const flssLoansData = this.apollo.readQuery({
query: flssLoansQueryExtended,
variables: prefetchedFlssVariables
});
cachedRecommendedLoans = flssLoansData?.fundraisingLoans?.values?.filter(loan => loan !== null) ?? [];
}

this.initializeFiveDollarsNotes();

Expand Down
38 changes: 38 additions & 0 deletions src/util/flssUtils.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import flssLoanQuery from '#src/graphql/query/flssLoansQuery.graphql';
import loanRecommendationsQuery from '#src/graphql/query/loanRecommendationsQuery.graphql';
import flssLoanFacetsQuery from '#src/graphql/query/flssLoanFacetsQuery.graphql';
import flssLoanChannelQuery from '#src/graphql/query/flssLoanChannel.graphql';
import categoryListFlssQuery from '#src/graphql/query/loanFinding/categoryListFlss.graphql';
Expand Down Expand Up @@ -124,6 +125,43 @@ export async function fetchLoans(
}
}

/**
* Fetches recommended loans from the FLSS API
*
* @param {Object} apollo The Apollo client instance
* @param {String} origin Origin of query formatted as web:##page-context##
* @param {Object} filters Optional filters to apply to recommendations
* @param {String} sortBy Sort option for recommendations (defaults to 'personalized')
* @param {Number} userId Optional user ID to get personalized recommendations
* @param {Number} limit Optional limit for the number of recommendations
* @returns {Object} The results of the recommendations query
*/
export async function fetchRecommendedLoans(
apollo,
origin = FLSS_ORIGIN_NOT_SPECIFIED,
filters = null,
sortBy = 'personalized',
userId = null,
limit = null,
) {
try {
const result = await apollo.query({
query: loanRecommendationsQuery,
variables: {
filterObject: filters,
sortBy,
origin,
userId,
limit,
},
fetchPolicy: 'network-only',
});
return result.data?.loanRecommendations;
} catch (e) {
logReadQueryError(e, 'flssUtils fetchRecommendedLoans');
}
}

/**
* Gets the variables for the loan channel query
*
Expand Down
32 changes: 32 additions & 0 deletions src/util/loanSearch/dataUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import loanEnumsQuery from '#src/graphql/query/loanEnumsQuery.graphql';
import {
fetchFacets,
fetchLoans,
fetchRecommendedLoans,
getFlssFilters,
FLSS_ORIGIN_NOT_SPECIFIED,
} from '#src/util/flssUtils';
Expand Down Expand Up @@ -53,6 +54,37 @@ export async function runLoansQuery(apollo, loanSearchState, origin) {
return { loans: flssData?.values?.filter(loan => loan !== null) ?? [], totalCount: flssData?.totalCount ?? 0 };
}

/**
* Runs the query to get recommended loans
*
* @param {Object} apollo The Apollo client instance
* @param {Object} options Query options including userId and origin
* @param {Number} options.userId The user ID to get recommendations for (optional)
* @param {String} options.origin Origin of query formatted as web:##page-context##
* @param {Object} options.filterObject Optional filters to apply to recommendations
* @param {String} options.sortBy Sort option for recommendations (defaults to 'personalized')
* @param {Number} options.limit Limit the number of recommendations (optional)
* @returns {Object} The results of the recommendations query
*/
export async function runRecommendationsQuery(apollo, {
dyersituations marked this conversation as resolved.
Show resolved Hide resolved
userId = null,
origin = FLSS_ORIGIN_NOT_SPECIFIED,
filterObject = null,
sortBy = 'personalized',
limit = null
} = {}) {
const flssData = await fetchRecommendedLoans(
apollo,
origin,
filterObject,
sortBy,
userId,
limit
);

return { loans: flssData?.values?.filter(loan => loan !== null) ?? [], totalCount: flssData?.totalCount ?? 0 };
}

/**
* Fetches the facets data for the lend and FLSS APIs
*
Expand Down
Loading
Loading