-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate FLSS with ERL email #5743
Conversation
}); | ||
|
||
// User IMG Router Recommendations (Kiva Classic) | ||
router.use('/recommendations/u/:id(\\d{0,})/img2/:offset(\\d{0,})', async (req, res) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this locally and encountered a server error. Is the new endpoint live and ready?
URL: https://kiva-ui.local/live-loan/recommendations/u/2230848/img2/1
Error on console locally: Error serving image, Error: No loans returned
Working alternative (old FLSS): https://kiva-ui.local/live-loan/flss/u/2230848/img2/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}`, | ||
variables: { | ||
userId: Number(id), | ||
limit: loanCount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michelleinez @dyersituations There might be an issue here with loanCount
...it's used below but not defined like this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it defined up above on line 11? It also looks like it was originally used in this same exact way down below in the FLSS fetch query...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it appears to be! But you,ll want to confirm the actual query operation and combination of variables and that the failure isn't somewhere in the code setup...
Closing this PR for now, will re-open when I figure out what the issue is with the URL internal server error |
No description provided.