Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds an option to allow add resources to Android res/ directory #1428

Closed
wants to merge 2 commits into from

Conversation

DexerBR
Copy link

@DexerBR DexerBR commented Apr 18, 2022

Depends on:

General explanations of feature need: #1397
Reference: https://developer.android.com/guide/topics/resources/providing-resources

Using specific solutions will not be enough in the long term, so this PR is intended to provide a more comprehensive option for managing android resources.

With the main intention of facilitating the use of the resource and its management, the user will only need to create a folder with the structure below, and pass its path to the android.add_res argument.

res/
    drawable/
        graphic.png
    anim/
        anim.xml
    mipmap/
        img.png
    xml/
        value.xml

I believe it's important to reset the dist res/ folder values to default directories and files before each copy/overwrite of user resource files, but I still haven't figured out how python-for-android do it.

PRs it can cover (at least partially) :
#1119
#1230
#1417

Maybe related issue: #167

@misl6
Copy link
Member

misl6 commented May 1, 2022

⚠️ There's a python-for-android related PR which is marked as WIP.
@DexerBR can you also mark this one as WIP until the python-for-android related PR is merged?

@DexerBR DexerBR changed the title Adds an option to allow add resources to Android res/ directory [WIP] Adds an option to allow add resources to Android res/ directory May 1, 2022
@DexerBR
Copy link
Author

DexerBR commented May 1, 2022

⚠️ There's a python-for-android related PR which is marked as WIP. @DexerBR can you also mark this one as WIP until the python-for-android related PR is merged?

Sure, done! 👍

@misl6
Copy link
Member

misl6 commented Nov 5, 2022

Superseded by #1513

Thank you!

@misl6 misl6 closed this Nov 5, 2022
@DexerBR DexerBR deleted the android_add_resources branch November 5, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants