-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
975 improve iphone launch sequence new #1000
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
- Coverage 40.00% 39.86% -0.15%
==========================================
Files 114 116 +2
Lines 6472 6618 +146
==========================================
+ Hits 2589 2638 +49
- Misses 3883 3980 +97 ☔ View full report in Codecov by Sentry. |
Previews:iPhone:iphone_light.moviphone_post_inst_dark.moviPad:ipad_first_inst_light.movmacOS:mac_os.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BPerlakiH After a first look, looks good modulo:
- The logo+buttons block is not centered vertically properly
- iphone_post_inst_dark.mov has still a spinner where we have said we son't have spinner there
@kelson42 I have updated so that the whole logo + button block is now vertically centered. ipad.moviphone_light.moviphone_land_dark.mov |
@BPerlakiH What about the spinner? |
@kelson42 That's seems to be good, the former recording was a post install (2nd time app launch) sequence, as you can see on the new screen recording, first time users won't have the spinner. |
Fixes: #975
Re-opening from: #976
What had to be changed:
This extra overhead with the original image size (and any change on the custom app side) can be avoided if we position the buttons (and loading text) relative to the screen height. The only difference will be that the space between the Logo and the buttons (and loading text) will be smaller or larger depending on the screen size.