Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Continuous Integration #538

Merged
merged 14 commits into from
Nov 17, 2023
Merged

Introducing Continuous Integration #538

merged 14 commits into from
Nov 17, 2023

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented Nov 15, 2023

Fixes #159

Building both macOS App and iOS App on every commit on main and on PRs.
Build is not used/uploaded but still requires to be signed.

⚠️ build command is ran up to twice as I didn't manage to reliably make it work otherwise. There are always No module 'CoreKiwix' errors.

Build is signed using an Apple Development certificate (in secrets)

@rgaudin
Copy link
Member Author

rgaudin commented Nov 15, 2023

⚠️ Awaiting tomorrow (2023-11-16) to change XCF_URL to nightly

kelson42
kelson42 previously approved these changes Nov 15, 2023
Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me.

Remarks:

  • not sure what is this ci branch in the workflow!?
  • should probably be rebased on libkiwix-13 branch

@rgaudin rgaudin changed the base branch from main to libkiwix-13 November 16, 2023 09:52
Building both macOS App and iOS App on every commit on `main` and on PRs.
Build is not used/uploaded but still requires to be signed.
Signing is done by automatically requesting appropriate Dev certificate using Store API Key.
Only “reliable” way I found to succeed build in CI
@rgaudin
Copy link
Member Author

rgaudin commented Nov 16, 2023

* not sure what is this `ci` branch in the workflow!?

Was for testing the actions before the PR

* should probably be rebased on `libkiwix-13` branch

Targets it now

Base automatically changed from libkiwix-13 to main November 17, 2023 15:59
@kelson42 kelson42 dismissed their stale review November 17, 2023 15:59

The base branch was changed.

@kelson42
Copy link
Contributor

All good with libkiwix 13.0.0!

@kelson42 kelson42 merged commit fba629b into main Nov 17, 2023
3 checks passed
@kelson42 kelson42 deleted the ci branch November 17, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Continous Integration
2 participants