fix: set description to undefined if decode fails #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kixelated
approved these changes
Nov 19, 2024
|
JK there's a typescript error |
kixelated
reviewed
Nov 19, 2024
lib/karp/catalog/video.ts
Outdated
|
|
||
| obj.description = Hex.decode(obj.description) | ||
| obj.description = obj.description ? Hex.decode(obj.description) : undefined |
There was a problem hiding this comment.
if (typeof obj.description === "string") {
obj.description = Hex.decode(obj.description)
} else if (obj.description !== undefined) {
return false;
}There was a problem hiding this comment.
on my phone on the train, untested
therishidesai
force-pushed
the
rdesai/undefined-description
branch
from
505dd36 to
25b16d0
Compare
therishidesai
commented
Nov 20, 2024
|
|
||
| obj.description = Hex.decode(obj.description) | ||
| obj.description = obj.description && typeof obj.description === "string" ? Hex.decode(obj.description) : undefined |
There was a problem hiding this comment.
I did this instead, it runs and also passes build and biome. Tested with both fMP4/AVCC and annexb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For H264 annexb format description is undefined since SPS/PPS are defined in the NALUs before a keyframe