Remove the custom deploy stuff for moq-pub. #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be in a separate repo/image.
|
context: I'm adding the word "chicago:" in front of the time on BBB. That doesn't make any sense to be included in a generic moq-rs image, as it's very specific to the hosting on GCP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be in a separate repo/image.
@englishm if you have a chance, could you also move the fly stuff into a separate repo/image? I think this repo should just provide compiled binaries without deploy/cloud gunk included.
Here's what I'm doing for the code that publishes BBB and the clock: https://github.com/kixelated/quic.video/blob/main/pub/Dockerfile
It does mean you have to build the final image separately, but it's not that bad and gives you more control over what you actually want to deploy.