Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sendMessageCompletion to handle BLEManagerError with human-readable message #17

Merged
merged 1 commit into from
May 6, 2024
Merged

Update sendMessageCompletion to handle BLEManagerError with human-readable message #17

merged 1 commit into from
May 6, 2024

Conversation

SOGAPPS
Copy link
Contributor

@SOGAPPS SOGAPPS commented May 6, 2024

Update sendMessageCompletion to handle BLEManagerError.noData case with human-readable message

  • For example current method returns: "The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)" for "No DATA" whilst running "DTC". It's not user friendly.

@SOGAPPS
Update sendMessageCompletion to handle BLEManagerError.noData case wi…
9a8c5ef 
…th human-readable message

- Current method retuns: "The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)" for "No DATA"
@kkonteh97 kkonteh97 merged commit 7c0574e into kkonteh97:main May 6, 2024
1 check passed
@kkonteh97
Copy link
Owner

that makes sense thanks

@SOGAPPS SOGAPPS deleted the feature/handle_ble_manager_error_cases branch May 6, 2024 15:57
@SOGAPPS SOGAPPS restored the feature/handle_ble_manager_error_cases branch May 7, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SOGAPPS @kkonteh97