Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos in Documentation Files #1551

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Typos in Documentation Files #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53cab65
typos eth_gasPrice.md
Dimitrolito Dec 11, 2024
937b14c
typos rpc_api_status.md
Dimitrolito Dec 11, 2024
4ae3ec2
typos README.md
Dimitrolito Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/methods/eth_gasPrice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ For this reason:

- gasPrice == baseFee
- priority fee is generally a variable that isn't used.
- setting a EIP-1559 transaction with `maxPriorityFeePerGas > 0` has no
- setting an EIP-1559 transaction with `maxPriorityFeePerGas > 0` has no
effect.
4 changes: 2 additions & 2 deletions docs/rpc_api_status.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ documented in `./methods/{method}.md`
| [eth_getCode](./methods/eth_getCode.md) | Returns code at a given address. | ✅ |
| eth_sign | The sign method calculates an Ethereum specific signature with: sign(keccak256("\x19Ethereum Signed Message:\n" + len(message) + message))). | ❎ |
| eth_signTransaction | Signs a transaction that can be submitted to the network at a later time using with eth_sendRawTransaction. | ❎ |
| eth_sendTransaction | Creates new message call transaction or a contract creation, if the data field contains code. | ❎ |
| [eth_sendRawTransaction](./methods/eth_sendRawTransaction.md) | Creates new message call transaction or a contract creation for signed transactions. | ✅ |
| eth_sendTransaction | Creates a new message call transaction or a contract creation, if the data field contains code. | ❎ |
| [eth_sendRawTransaction](./methods/eth_sendRawTransaction.md) | Creates a new message call transaction or a contract creation for signed transactions. | ✅ |
| [eth_call](./methods/eth_call.md) | Executes a new message call immediately without creating a transaction on the blockchain. | ✅ |
| [eth_estimateGas](./methods/eth_estimateGas.md) | Generates and returns an estimate of how much gas is necessary to allow the transaction to complete. | ✅ |
| eth_getBlockByHash | Returns information about a block by hash. | ✅ |
Expand Down
2 changes: 1 addition & 1 deletion indexer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ _Why not directly modify a CairoVM client?_
[Madara](https://madara-docs.vercel.app/)).

<details>
<summary>For reference, click to see how the above mentioned monolithic architecture
<summary>For reference, click to see how the above-mentioned monolithic architecture
would look like (note that it is not the current architecture of Kakarot zkEVM):
</summary>

Expand Down