Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: clippy::nursery non breaking #653

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

bhavyagosai
Copy link
Contributor

Time spent on this PR: 2 hours

Related: #584

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Applied clippy::nursery lints

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice first PR (if i'm not mistaken)
welcome

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 376 lines in your changes are missing coverage. Please review.

Comparison is base (71506a8) 23.17% compared to head (4a9e1da) 79.71%.
Report is 246 commits behind head on main.

Files Patch % Lines
crates/core/src/client/mod.rs 77.05% 92 Missing ⚠️
crates/core/src/client/config.rs 29.88% 61 Missing ⚠️
crates/core/src/client/helpers.rs 65.04% 43 Missing ⚠️
crates/core/src/client/errors.rs 10.00% 36 Missing ⚠️
crates/core/src/contracts/kakarot.rs 60.52% 30 Missing ⚠️
crates/core/src/mock/mock_starknet.rs 82.35% 27 Missing ⚠️
crates/core/src/client/waiter.rs 65.11% 15 Missing ⚠️
crates/core/src/contracts/contract_account.rs 75.51% 12 Missing ⚠️
crates/core/src/models/call.rs 92.98% 12 Missing ⚠️
crates/core/src/models/block.rs 95.02% 11 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #653       +/-   ##
===========================================
+ Coverage   23.17%   79.71%   +56.53%     
===========================================
  Files           9       44       +35     
  Lines        1247     3446     +2199     
===========================================
+ Hits          289     2747     +2458     
+ Misses        958      699      -259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix added this pull request to the merge queue Nov 20, 2023
Merged via the queue into kkrt-labs:main with commit 698737e Nov 20, 2023
8 checks passed
@bhavyagosai
Copy link
Contributor Author

lgtm! nice first PR (if i'm not mistaken) welcome

yes its my first PR!

@bhavyagosai bhavyagosai deleted the nursery-non-breaking branch November 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants