feat: add MemoryTable struct #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
reviewed
Nov 8, 2024
|
|
||
| impl MemoryTableRow { | ||
| pub fn new(clk: BaseField, mp: BaseField, mv: BaseField) -> Self { | ||
| Self { clk, mp, mv, d: BaseField::zero() } |
There was a problem hiding this comment.
Suggested change
| Self { clk, mp, mv, d: BaseField::zero() } | |
| Self { clk, mp, mv, ..Default::default() } |
tcoratger
reviewed
Nov 8, 2024
| /// # Returns | ||
| /// A new instance of [`MemoryTable`] with an empty table. | ||
| pub const fn new() -> Self { | ||
| Self { table: Vec::new() } |
There was a problem hiding this comment.
Suggested change
| Self { table: Vec::new() } | |
| Self::default() |
There was a problem hiding this comment.
Oh, didn't catch it indeed
We've got the same in instruction/table.rs
There was a problem hiding this comment.
However, it requires not having the new method as const (or implement Default as const ?)
tcoratger
reviewed
Nov 8, 2024
Comment on lines
24
to
30
| pub fn new(clk: BaseField, mp: BaseField, mv: BaseField) -> Self { | ||
| Self { clk, mp, mv, d: BaseField::zero() } | ||
| } | ||
|
|
||
| pub fn new_dummy(clk: BaseField, mp: BaseField, mv: BaseField) -> Self { | ||
| Self { clk, mp, mv, d: BaseField::one() } | ||
| } |
There was a problem hiding this comment.
Here really pedantic but I think that we miss 2 small unit tests:
- To validate that the fields clk, mp, mv, d are properly set up for a row with the
newfunction - To validate that the fields clk, mp, mv, d are properly set up for a row with the
new_dummyfunction
There was a problem hiding this comment.
Indeed, I'll add them
tcoratger
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
The field
drepresenting the flag for dummy rows is private:dmust either be 0 or 1 (as a BaseField), which is enforced by the methodsnewandnew_dummy.This field
dappears useless atm, but it'll make more sense once #33 and #34 are done.