Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IOTable trace #48

Merged
merged 5 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/brainfuck_prover/src/components/io/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pub mod table;
234 changes: 234 additions & 0 deletions crates/brainfuck_prover/src/components/io/table.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,234 @@
use crate::utils::{INPUT_INSTRUCTION, OUTPUT_INSTRUCTION};
use brainfuck_vm::registers::Registers;
use stwo_prover::core::fields::m31::BaseField;

/// Represents a single row in the I/O Table.
///
/// The I/O Table stores:
/// - The memory value (`mv`),
#[derive(Debug, Default, PartialEq, Eq, Clone)]
pub struct IOTableRow {
/// Memory value: value of the cell pointer by `mp` - values in [0..2^31 - 1)
pub mv: BaseField,
}

impl IOTableRow {
pub const fn new(mv: BaseField) -> Self {
Self { mv }
}
}

/// Represents the I/O Table, which holds the required register
/// for the Input and Output components.
#[derive(Debug, Default, PartialEq, Eq, Clone)]
pub struct IOTable<const N: u32> {
/// A vector of [`IOTableRow`] representing the table rows.
pub table: Vec<IOTableRow>,
}

impl<const N: u32> IOTable<N> {
/// Creates a new, empty [`IOTable`].
///
/// # Returns
/// A new instance of [`IOTable`] with an empty table.
pub fn new() -> Self {
Self::default()
}

/// Adds a new row to the I/O Table from the provided register.
///
/// # Arguments
/// * `mv` - The memory value for the new row.
///
/// This method pushes a new [`IOTableRow`] onto the `table` vector.
pub fn add_row_from_register(&mut self, mv: BaseField) {
self.table.push(IOTableRow { mv });
}

/// Adds a new row to the I/O Table.
///
/// # Arguments
/// * `row` - The [`IOTableRow`] to add to the table.
///
/// This method pushes a new [`IOTableRow`] onto the `table` vector.
pub fn add_row(&mut self, row: IOTableRow) {
self.table.push(row);
}

/// Adds multiple rows to the I/O Table.
///
/// # Arguments
/// * `rows` - A vector of [`IOTableRow`] to add to the table.
///
/// This method extends the `table` vector with the provided rows.
pub fn add_rows(&mut self, rows: Vec<IOTableRow>) {
self.table.extend(rows);
}

/// Retrieves a reference to a specific row in the I/O Table.
///
/// # Arguments
/// * `row` - The [`IOTableRow`] to search for in the table.
///
/// # Returns
/// An `Option` containing a reference to the matching row if found,
/// or `None` if the row does not exist in the table.
pub fn get_row(&self, row: &IOTableRow) -> Option<&IOTableRow> {
self.table.iter().find(|r| *r == row)
}
}

impl<const N: u32> From<Vec<Registers>> for IOTable<N> {
fn from(registers: Vec<Registers>) -> Self {
let mut io_table = Self::new();
let rows = registers
.into_iter()
.filter(|register| register.ci == BaseField::from_u32_unchecked(N))
.map(|x| IOTableRow { mv: x.mv })
.collect();
io_table.add_rows(rows);

io_table
}
}

/// Input table (trace) for the Input component.
///
/// This table is made of the memory values (`mv` register) corresponding to
/// inputs (when the current instruction `ci` equals ',').
pub type InputTable = IOTable<INPUT_INSTRUCTION>;

/// Output table (trace) for the Output component.
///
/// This table is made of the memory values (`mv` register) corresponding to
/// outputs (when the current instruction `ci` equals '.').
pub type OutputTable = IOTable<OUTPUT_INSTRUCTION>;

#[cfg(test)]
mod tests {
use super::*;
use num_traits::One;

type TestIOTable = IOTable<10>;

#[test]
fn test_io_row_new() {
let row = IOTableRow::new(BaseField::from(91));
let expected_row = IOTableRow { mv: BaseField::from(91) };
assert_eq!(row, expected_row);
}

#[test]
fn test_table_new() {
let io_table = TestIOTable::new();
assert!(io_table.table.is_empty(), "I/O Table should be empty upon initialization.");
}

#[test]
fn test_table_add_row_from_register() {
let mut io_table = TestIOTable::new();
// Create a row to add to the table
let row = IOTableRow::new(BaseField::from(91));
// Add the row to the table
io_table.add_row_from_register(BaseField::from(91));
// Check that the table contains the added row
assert_eq!(io_table.table, vec![row], "Added row should match the expected row.");
}

#[test]
fn test_table_add_row() {
let mut io_table = TestIOTable::new();
// Create a row to add to the table
let row = IOTableRow::new(BaseField::from(91));
// Add the row to the table
io_table.add_row(row.clone());
// Check that the table contains the added row
assert_eq!(io_table.table, vec![row], "Added row should match the expected row.");
}

#[test]
fn test_table_add_multiple_rows() {
let mut io_table = TestIOTable::new();
// Create a vector of rows to add to the table
let rows = vec![
IOTableRow::new(BaseField::from(91)),
IOTableRow::new(BaseField::from(9)),
IOTableRow::new(BaseField::from(43)),
];
// Add the rows to the table
io_table.add_rows(rows.clone());
// Check that the table contains the added rows
assert_eq!(io_table, IOTable { table: rows });
}

#[test]
fn test_table_get_existing_row() {
let mut io_table = TestIOTable::new();
// Create a row to add to the table
let row = IOTableRow { mv: BaseField::from(91) };
// Add the row to the table
io_table.add_row(row.clone());
// Retrieve the row from the table
let retrieved = io_table.get_row(&row);
// Check that the retrieved row matches the added row
assert_eq!(retrieved.unwrap(), &row, "Retrieved row should match the added row.");
}

#[test]
fn test_table_get_non_existing_row() {
let io_table = TestIOTable::new();
// Create a row to search for in the table
let row = IOTableRow { mv: BaseField::from(91) };
// Try to retrieve the non-existing row from the table
let retrieved = io_table.get_row(&row);
// Check that the retrieved row is None
assert!(retrieved.is_none(), "Should return None for a non-existing row.");
}

#[test]
fn test_input_table_from_registers() {
let reg1 = Registers::default();
let reg2 = Registers {
mv: BaseField::one(),
ci: BaseField::from(INPUT_INSTRUCTION),
..Default::default()
};
let reg3 = Registers {
mv: BaseField::from(5),
ci: BaseField::from(OUTPUT_INSTRUCTION),
..Default::default()
};
let registers: Vec<Registers> = vec![reg3, reg1, reg2];

let row = IOTableRow::new(BaseField::one());
// let row = IOTableRow::new(BaseField::from(5));

let mut expected_io_table: InputTable = IOTable::new();
expected_io_table.add_row(row);

assert_eq!(IOTable::from(registers), expected_io_table);
}

#[test]
fn test_output_table_from_registers() {
let reg1 = Registers::default();
let reg2 = Registers {
mv: BaseField::one(),
ci: BaseField::from(INPUT_INSTRUCTION),
..Default::default()
};
let reg3 = Registers {
mv: BaseField::from(5),
ci: BaseField::from(OUTPUT_INSTRUCTION),
..Default::default()
};
let registers: Vec<Registers> = vec![reg3, reg1, reg2];

let row = IOTableRow::new(BaseField::from(5));

let mut expected_io_table: OutputTable = IOTable::new();
expected_io_table.add_row(row);

assert_eq!(IOTable::from(registers), expected_io_table);
}
}
1 change: 1 addition & 0 deletions crates/brainfuck_prover/src/components/mod.rs
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
pub mod instruction;
pub mod io;
pub mod memory;