Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rust toolchain update to trunk ci #86

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: add rust toolchain update to trunk ci #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da6ba63
fix: add rust downloads for the ci in trunk
zmalatrax Nov 22, 2024
510a30b
doc: add return for trace_evaluation of memory
zmalatrax Nov 22, 2024
14b8144
fix: add rust cache
zmalatrax Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/trunk-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- run: rustup update
- name: Rust cache
uses: Swatinem/rust-cache@v2
with:
cache-on-failure: "true"

- name: Trunk Code Quality
uses: trunk-io/trunk-action@v1
6 changes: 6 additions & 0 deletions crates/brainfuck_prover/src/components/memory/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ impl MemoryTable {
///
/// # Arguments
/// * memory - The [`MemoryTable`] containing the sorted and padded trace as an array of rows.
///
/// # Returns
/// A tuple containing the evaluated trace and claim for STARK proof.
///
/// # Errors
/// Returns [`TraceError::EmptyTrace`] if the table is empty.
pub fn trace_evaluation(&self) -> Result<(TraceEval, Claim), TraceError> {
let n_rows = self.table.len() as u32;
if n_rows == 0 {
Expand Down