Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support minification & refactoring #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

odedniv
Copy link

@odedniv odedniv commented Jul 15, 2015

  • support minification
  • rename scope attributes
  • fix timeouts
  • allow <div masonry> syntax
  • allow items to not be direct descendants
  • destroy masonry when scope destroyed

- support minification
- rename scope attributes
- fix timeouts
- allow `<div masonry>` syntax
- allow items to not be direct descendants
- destroy masonry when scope destroyed
elem.children(options.itemSelector).css('visibility', 'visible');
}, 120);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure why these high timeouts exist (and not 0 to append to the end of the digest queue). Hope you could shed some light on it.

@viking2917
Copy link

Not sure if I am doing something wrong, but this line is giving me trouble:
var master = elem.parents(

when executed, the error is "parents" is not a function. the original has "parent", not "parents".

It's also not working with my minification process but that may well be my error.

@odedniv
Copy link
Author

odedniv commented Aug 1, 2015

@viking2917,

Oops, I include jquery in my project which is why I had the parents function. Do you know another way for it to work? To find the closest parent with jquery lite? Because the current implementation only finds the direct parent. Maybe it's fine, but then it probably needs to be documented.

What do you mean not working with minification? The change I made for that was to specify the name of the dependencies ($timeout) with strings, because minification ruins the names of variables, which should make angular unable to determine the dependencies from the argument names of the function.

@viking2917
Copy link

I've confirmed the problem I had with minification was my own problem, not related to your changes, sorry for the confusion.

I don't need the functionality to include anything other than the direct parent. I also don't know of a one-liner to get all ancestors in pure javascript, I suppose you'd have to iterate up the DOM with multiple parent() calls....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants