feat(versioning-proxy): implement a versioning proxy standard and derive an Arbitrator proxy #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
force-pushed
the
feat/versioning-proxy
branch
from
e3269ea to
739a55c
Compare
|
Could you make the proxy a general Arbitrator proxy and not Kleros specific? |
|
@clesaege OK. |
…ded functionality
epiqueras
changed the title
clesaege
requested changes
Mar 2, 2018
| return _disputeID; | ||
| } | ||
|
|
||
| function appeal(uint256 _disputeID, bytes _extraData) public payable onlyIfDisputeExists(_disputeID) returns(uint256 _newDisputeID) { |
There was a problem hiding this comment.
Appeal does not return anything, see ethereum/EIPs#792
So in case the appeals goes to a new arbitrator you have to deal with the fact that disputeID are not gonna be the same for the proxy and the arbitratrator. A possible implementation would be to have a mapping:
disputeID->(arbitrator,disputeIDinThisArbitrator).
There was a problem hiding this comment.
To avoid incorrect implementation of the standard, you could make it inherit from Arbitrator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19