Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot grid option to Itinerary elements #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmg
Copy link

@gmg gmg commented Nov 6, 2023

First iteration of adding dot grid option to Itinerary elements, including:

  • methods to render dot grid lines in Itinerary
  • UI to set dot grid option
  • config settings for dot grid option

Please note- I am not very experienced with React, so there's every possibility that I have not done this in the optimal way.

First iteration of adding dot grid option to Itinerary elements, including:
- methods to render dot grid lines in Itinerary
- UI to set dot grid option
- config settings for dot grid option
@gmg gmg changed the title Added dot grid option to Itinerary elements Add dot grid option to Itinerary elements Nov 6, 2023
@gmg
Copy link
Author

gmg commented Nov 6, 2023

After a bit more testing, it seems that this method does not work well with very large ReCalendar configs (more pages). If you choose a large number of pages with itineraries - months, days, weekly retrospectives - it will run out of memory when trying to render the full document. Smaller setups work, but take noticably longer that the original lines versions. File sizes are larger, but not excessively so.

At this point, I'm going to need to turn this over to smarter people. Rendering the dots as View elements obviously means 20x more visual elements compared to lines, which I'm guessing ends up being too much for the PDF renderer. Is there a more performant way of generating lines of dots?

@mihaibirsan
Copy link

There seem to be a few alternatives for a more performant implementation:

Oh! And make sure you rebase on top of master so the PR can be accepted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants