Commented out the attributes that are not implemented in Burrito #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This information may be usefull elsewhere. The value is checked to be inside the expected range.
Co-authored-by: Asher Glick <[email protected]>
Improve the bug workarounds section
To avoid code duplication the core functionality of _on_Dialog_hide was moved to an independet function.
This check does not hold a real value while most components of burrito only work reliable on fullscreen anyway.
Instead of calculating the position it is now directly read from a dictionary as an absolute value.
Dynamic icon positon depending on ui-scale
Dynamic minimap scale depending on ui-scale
Quick fix for nested types and bad trl paths
Update XML parsing to ignore XML prefixes from tags
Cleaning up burrito link code to make it more readable
Contains the base struct to identify the dll as a compatible addon.
Add basic compatibility with RaidcoreGG-Nexus
Removing the timestamp from the dll
Merging master changes into xml_converter
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.bin.textproto._old 2024-09-25 04:08:41.056112775 +0000
+++ xml_converter/integration_tests/test_cases/xml_animation_speed/output_proto/markers.bin.textproto._new 2024-09-25 04:08:41.059112757 +0000
@@ -1,182 +0,0 @@
-category {
- name: "My Category"
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 1
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: 123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -3.14
- }
- trail {
- map_id: 50
- trail_data {
- points_x: 1
- points_x: 2
- points_x: 3
- points_y: 4
- points_y: 5
- points_y: 6
- points_z: 7
- points_z: 8
- points_z: 9
- }
- animation_speed: -123.456
- }
- id: "(\350\314\006\302\223^\226"
-}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.bin.textproto._old 2024-09-25 04:08:41.071112686 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.bin.textproto._new 2024-09-25 04:08:41.078112644 +0000
@@ -71,7 +71,6 @@
points_z: 8
points_z: 9
}
- animation_speed: 1
}
id: "\361@\242\320/\212\204\001"
}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.bin.textproto._old 2024-09-25 04:08:41.089112579 +0000
+++ xml_converter/integration_tests/test_cases/xml_fade_distance/output_proto/markers.bin.textproto._new 2024-09-25 04:08:41.092112561 +0000
@@ -1,87 +0,0 @@
-category {
- name: "My Category"
- icon {
- map_id: 50
- distance_fade_end: 1
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- distance_fade_start: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 3.14
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- icon {
- map_id: 50
- distance_fade_end: 123.456
- position {
- x: 169.81
- y: 210.65
- z: 215.83
- }
- }
- trail {
- distance_fade_end: 3.14
- }
- trail {
- distance_fade_end: 3.14159
- distance_fade_start: 3.14
- }
- trail {
- distance_fade_end: 3.14
- }
- id: "(\350\314\006\302\223^\226"
-}
klingbolt
force-pushed
the
xml_converter
branch
from
fc56dc5 to
4637b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See AsherGlick#151 for details on why these attributes are temporarily being commented out within the protobuf.
Reliant on AsherGlick#358