Return "namespace not found" error to allow future reconciliation if …

…namespace is created later

Signed-off-by: Rokibul Hasan <[email protected]>

pkg/agent/controller/managedclusterrolebinding_controller.go

@@ -115,13 +115,10 @@ func (r *ManagedClusterRoleBindingReconciler) Reconcile(ctx context.Context, req
 		}
 	} else {
 		for _, ns := range managedCRB.RoleRef.Namespaces {
-			exist, err := utils.IsNamespaceExist(r.SpokeClient, ns)
+			_, err := utils.IsNamespaceExist(r.SpokeClient, ns)
 			if err != nil {
 				return reconcile.Result{}, err
 			}
-			if !exist {
-				continue
-			}
 
 			givenRolebinding := &rbac.RoleBinding{
 				TypeMeta: metav1.TypeMeta{

pkg/utils/util.go

@@ -24,7 +24,6 @@ import (
 	authorizationv1alpha1 "github.com/kluster-manager/cluster-auth/apis/authorization/v1alpha1"
 
 	corev1 "k8s.io/api/core/v1"
-	kerr "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
@@ -59,9 +58,7 @@ func ExtractServiceAccountNameAndNamespace(s string) (name, namespace string, er
 func IsNamespaceExist(kc client.Client, name string) (bool, error) {
 	var ns corev1.Namespace
 	err := kc.Get(context.Background(), types.NamespacedName{Name: name}, &ns)
-	if err != nil && kerr.IsNotFound(err) {
-		return false, nil
-	} else if err != nil {
+	if err != nil {
 		return false, err
 	}
 	return true, nil