Skip to content

Commit

Permalink
Use recommended instead of required for Feature and FeatureSet
Browse files Browse the repository at this point in the history
Signed-off-by: Masudur Rahman <[email protected]>
  • Loading branch information
masudur-rahman committed Sep 29, 2023
1 parent aaf22a2 commit 14d26f1
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion apis/ui/v1alpha1/feature_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type FeatureSpec struct {
FeatureBlock string `json:"featureBlock,omitempty"`
// Required specifies whether this feature is mandatory or not for enabling the respecting FeatureSet.
// +optional
Required bool `json:"required,omitempty"`
Recommended bool `json:"recommended,omitempty"`
// Requirements specifies the requirements to enable this feature.
// +optional
Requirements Requirements `json:"requirements,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion apis/ui/v1alpha1/featureset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type FeatureSetSpec struct {
Icons []helmshared.ImageSpec `json:"icons,omitempty"`
// Required specify whether this feature set is mandatory or not for using the UI.
// +optional
Required bool `json:"required,omitempty"`
Recommended bool `json:"recommended,omitempty"`
// RequiredFeatures specifies list of features that are necessary to consider this feature set as ready.
// +optional
RequiredFeatures []string `json:"requiredFeatures,omitempty"`
Expand Down
4 changes: 2 additions & 2 deletions apis/ui/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crds/ui.k8s.appscode.com_features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ spec:
type: object
type: array
type: object
required:
recommended:
description: Required specifies whether this feature is mandatory
or not for enabling the respecting FeatureSet.
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion crds/ui.k8s.appscode.com_featuresets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ spec:
- src
type: object
type: array
required:
recommended:
description: Required specify whether this feature set is mandatory
or not for using the UI.
type: boolean
Expand Down

0 comments on commit 14d26f1

Please sign in to comment.