Fix NodeTopology crd

Signed-off-by: Tamal Saha <[email protected]>
kmodules · Jun 10, 2024 · 3a520e3 · 3a520e3
1 parent 2bd1940
commit 3a520e3
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/apis/node/v1alpha1/nodetopology_types.go b/apis/node/v1alpha1/nodetopology_types.go
@@ -52,7 +52,6 @@ type NodeTopologySpec struct {
 	// Requirements are layered with GetLabels and applied to every node.
 	// +kubebuilder:validation:XValidation:message="requirements with operator 'In' must have a value defined",rule="self.all(x, x.operator == 'In' ? x.values.size() != 0 : true)"
 	// +kubebuilder:validation:XValidation:message="requirements operator 'Gt' or 'Lt' must have a single positive integer value",rule="self.all(x, (x.operator == 'Gt' || x.operator == 'Lt') ? (x.values.size() == 1 && int(x.values[0]) >= 0) : true)"
-	// +kubebuilder:validation:XValidation:message="requirements with 'minValues' must have at least that many values specified in the 'values' field",rule="self.all(x, (x.operator == 'In' && has(x.minValues)) ? x.values.size() >= x.minValues : true)"
 	// +kubebuilder:validation:MaxItems:=30
 	// +optional
 	Requirements []core.NodeSelectorRequirement `json:"requirements,omitempty" hash:"ignore"`

diff --git a/crds/node.k8s.appscode.com_nodetopologies.yaml b/crds/node.k8s.appscode.com_nodetopologies.yaml
@@ -104,10 +104,6 @@ spec:
                     integer value
                   rule: 'self.all(x, (x.operator == ''Gt'' || x.operator == ''Lt'')
                     ? (x.values.size() == 1 && int(x.values[0]) >= 0) : true)'
-                - message: requirements with 'minValues' must have at least that many
-                    values specified in the 'values' field
-                  rule: 'self.all(x, (x.operator == ''In'' && has(x.minValues)) ?
-                    x.values.size() >= x.minValues : true)'
               topologyKey:
                 type: string
             required:

diff --git a/hub/resourcedescriptors/node.k8s.appscode.com/v1alpha1/nodetopologies.yaml b/hub/resourcedescriptors/node.k8s.appscode.com/v1alpha1/nodetopologies.yaml
@@ -119,10 +119,6 @@ spec:
                   integer value
                 rule: 'self.all(x, (x.operator == ''Gt'' || x.operator == ''Lt'')
                   ? (x.values.size() == 1 && int(x.values[0]) >= 0) : true)'
-              - message: requirements with 'minValues' must have at least that many
-                  values specified in the 'values' field
-                rule: 'self.all(x, (x.operator == ''In'' && has(x.minValues)) ? x.values.size()
-                  >= x.minValues : true)'
             topologyKey:
               type: string
           required: