Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the composite prober for the sink #3267

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Using the composite prober for the sink #3267

merged 1 commit into from
Sep 8, 2023

Conversation

Rahul-Kumar-prog
Copy link
Contributor

Fixes #3189

Proposed Changes

  • Update the Kafka_sink controller to use the prober with tls if the transport encryption flag is set to strict.

Release Note

The Kafka_sink now uses a tls-enabled prober if the transport encryption flag is set to strict.

Docs

@knative-prow knative-prow bot added area/control-plane needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

Hi @Rahul-Kumar-prog. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #3267 (5831429) into main (8a0ffa2) will decrease coverage by 1.64%.
Report is 40 commits behind head on main.
The diff coverage is 46.15%.

@@             Coverage Diff              @@
##               main    #3267      +/-   ##
============================================
- Coverage     63.56%   61.92%   -1.64%     
+ Complexity      774      767       -7     
============================================
  Files           170      181      +11     
  Lines         11957    12217     +260     
  Branches        250      268      +18     
============================================
- Hits           7600     7565      -35     
- Misses         3779     4064     +285     
- Partials        578      588      +10
Flag Coverage Δ
java-unittests 72.28% <ø> (-7.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
control-plane/pkg/reconciler/sink/controller.go 67.41% <22.22%> (-12.32%) ⬇️
control-plane/pkg/reconciler/sink/kafka_sink.go 75.23% <100.00%> (+1.10%) ⬆️

... and 27 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member

Cali0707 commented Aug 3, 2023

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 August 3, 2023 18:59
@Cali0707 Cali0707 mentioned this pull request Aug 4, 2023
Merged
@Cali0707
Copy link
Member

Cali0707 commented Aug 8, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2023
Cali0707
Cali0707 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@Cali0707
Copy link
Member

/cc @creydr @matzew

@knative-prow knative-prow bot requested a review from creydr August 11, 2023 19:03
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Aug 16, 2023

/retest-required

@Cali0707
Copy link
Member

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi August 21, 2023 13:34
@Rahul-Kumar-prog
Copy link
Contributor Author

Hey @Cali0707 what is the status of this issue ??

@Cali0707
Copy link
Member

Cali0707 commented Sep 7, 2023

Hey @Cali0707 what is the status of this issue ??

Currently waiting for someone to provide a second review. I will ask people on slack for another review

pierDipi
pierDipi approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rahul-Kumar-prog and @Cali0707, well done!

/approve

@knative-prow
Copy link

knative-prow bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi, Rahul-Kumar-prog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Sep 8, 2023

/retest-required

@matzew
Copy link
Contributor

matzew commented Sep 8, 2023

/test channel-integration-tests-ssl

@knative-prow knative-prow bot merged commit 1e36978 into knative-extensions:main Sep 8, 2023
0 of 2 checks passed
Leo6Leo pushed a commit to Leo6Leo/eventing-kafka-broker that referenced this pull request Dec 5, 2023
@Rahul-Kumar-prog @Leo6Leo
Using the composite prober for the sink (knative-extensions#3267)
0400a6f
Leo6Leo pushed a commit to Leo6Leo/eventing-kafka-broker that referenced this pull request Dec 15, 2023
@Rahul-Kumar-prog @Leo6Leo
Using the composite prober for the sink (knative-extensions#3267)
027e5ea
Leo6Leo pushed a commit to Leo6Leo/eventing-kafka-broker that referenced this pull request Dec 15, 2023
@Rahul-Kumar-prog @Leo6Leo
Using the composite prober for the sink (knative-extensions#3267)
a447678
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Dec 18, 2023
@Leo6Leo @Rahul-Kumar-prog @Cali0707
[release-v1.11] Cherry-pick E2E tests for channel: TLS key pair rotat…
b93a375 
…ion knative-extensions#3406 (#923)

* Using the composite prober for the sink (knative-extensions#3267)

* Cherry-pick 57c4d1e

* Cherry-pick 82651c9

---------

Co-authored-by: Rahul kumar <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Dec 21, 2023
@Leo6Leo @Rahul-Kumar-prog @pierDipi
[release-v1.11] Cherry-pick E2E tests for sink: TLS key pair rotation (…
5b9e57f 
…#925)

* Using the composite prober for the sink (knative-extensions#3267)

* E2E tests for sink: TLS key pair rotation (knative-extensions#3395)

* Exposing the 8443 port for https

* Add the test implementation

* Fix the custom resource definition

Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Fix the custom resource definition

Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Go formt and imports

* Adding the configmap watcher feature store

* Formatting issue

---------

Co-authored-by: Pierangelo Di Pilato <[email protected]>

---------

Co-authored-by: Rahul kumar <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
knative-prow bot pushed a commit that referenced this pull request Jan 8, 2024
@Leo6Leo @Rahul-Kumar-prog @pierDipi
[release-1.11] Cherry-pick E2E tests for sink: TLS key pair rotation (#…
24f00af 
…3510)

* Using the composite prober for the sink (#3267)

* E2E tests for sink: TLS key pair rotation (#3395)

* Exposing the 8443 port for https

* Add the test implementation

* Fix the custom resource definition

Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Fix the custom resource definition

Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Go formt and imports

* Adding the configmap watcher feature store

* Formatting issue

---------

Co-authored-by: Pierangelo Di Pilato <[email protected]>

---------

Co-authored-by: Rahul kumar <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@pierDipi pierDipi pierDipi approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

@creydr creydr Awaiting requested review from creydr

Assignees

@pierDipi pierDipi

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the composite prober for the sink
5 participants
@Rahul-Kumar-prog @Cali0707 @Leo6Leo @matzew @pierDipi