Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename knative-sandbox to knative-extensions #3268

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

davidhadas
Copy link
Contributor

@davidhadas davidhadas commented Aug 4, 2023

This is an automated PR to replace knative-sandbox strings with knative-extensions

@knative-prow knative-prow bot added area/test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #3268 (568c040) into main (24ef5f8) will increase coverage by 0.02%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #3268      +/-   ##
============================================
+ Coverage     61.89%   61.91%   +0.02%     
- Complexity      765      766       +1     
============================================
  Files           181      181              
  Lines         12200    12200              
  Branches        268      268              
============================================
+ Hits           7551     7554       +3     
+ Misses         4061     4059       -2     
+ Partials        588      587       -1     
Flag Coverage Δ
java-unittests 72.12% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
control-plane/pkg/security/secret.go 100.00% <ø> (ø)
control-plane/pkg/reconciler/broker/broker.go 72.50% <100.00%> (ø)
...lane/pkg/reconciler/consumergroup/consumergroup.go 52.73% <100.00%> (ø)

... and 1 file with indirect coverage changes

@davidhadas davidhadas changed the title HoldTillRename: Rename knative-sandbox to knative-extensions Rename knative-sandbox to knative-extensions Aug 4, 2023
@davidhadas
Copy link
Contributor Author

/retest

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @creydr @matzew

@knative-prow knative-prow bot requested review from creydr and matzew August 11, 2023 19:00
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr, davidhadas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@creydr
Copy link
Contributor

creydr commented Aug 14, 2023

/retest

@knative-prow knative-prow bot merged commit 4ceaa42 into knative-extensions:main Aug 14, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants