Add benchmark filter run script #3271
Conversation
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
knative-prow
bot
added
size/L
Codecov Report
@@ Coverage Diff @@
## main #3271 +/- ##
============================================
- Coverage 61.89% 61.82% -0.07%
- Complexity 765 766 +1
============================================
Files 181 181
Lines 12200 12220 +20
Branches 268 266 -2
============================================
+ Hits 7551 7555 +4
- Misses 4061 4078 +17
+ Partials 588 587 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Calum Murray <[email protected]>
|
/cc @Leo6Leo |
|
/retest-required |
1 similar comment
|
/retest-required |
Signed-off-by: Calum Murray <[email protected]>
This should be fixed now! |
There was a problem hiding this comment.
Running benchmarks for ExactFilterBenchmarkjjkyj
No matching benchmarks. Miss-spelled regexp?
Use EXTRA verbose mode to debug the pattern matching.
Successfully ran benchmarks for ExactFilterBenchmarkjjkyj!\n\nThe results can be found at /home/leoli/Downloads/eventing-kafka-broker/data-plane/benchmarks/output/ExactFilterBenchmarkjjkyj.1691602228.out.txt
When the input is wrong, the error is this. And it will run the build first as well. If the className sanity check happens at the beginning, it can save some time and resources
Signed-off-by: Calum Murray <[email protected]>
|
/cc @Leo6Leo |
|
/lgtm |
Signed-off-by: Calum Murray <[email protected]>
|
/cc @matzew |
|
/retest-required |
| while IFS="" read -r p || [[ -n "$p" ]]; do | ||
| if [[ "$1" == "$p" ]]; then | ||
| FOUND=1 | ||
| break | ||
| fi | ||
| done <"${SCRIPT_DIR}/resources/filter-class-list.txt" |
There was a problem hiding this comment.
Not an issue, but more a question: why didn't you use something like egrep -q "^${1}$"
There was a problem hiding this comment.
Just didn't think of it as I had already written the loop to go through the lines of filter-class-list.txt to run the benchmarks for all of the classes 😄
There was a problem hiding this comment.
@creydr do you think I should switch? Your solution does seem cleaner to me
There was a problem hiding this comment.
Whatever you prefer. I am fine with both
There was a problem hiding this comment.
I think i'll leave it for now since it keeps the script more consistent with itself
|
/retest |
|
/lgtm /hold |
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
/retest-required |
knative-prow
bot
merged commit c402ae9
into
knative-extensions:main
Fixes #3270
Proposed Changes
run.shscript in the benchmark project to run the benchmarksrun.shscript runnable fromhack/run.shDEVELOPMENT.mdon how to run the script