Bump go-licenses to new version #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
|
For reviews. |
knative-prow
bot
added
the
do-not-merge/hold
upodroid
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
And a follow-up question. With the changes to
go runin hack's scripts, is it even needed here?
No, but this image is used on older release branches that haven't had that patch cherry-picked to it. Also this image was written before we starting doing go run to reduce the need for vendoring
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my previous PR, I've noticed version mismatch between knative/hack and Prow image.
And a follow-up question. With the changes to
go runin hack's scripts, is it even needed here?/cc @cardil @upodroid