Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Support for themes #3

Open
shalvah opened this issue Jun 27, 2020 · 5 comments
Open

Support for themes #3

shalvah opened this issue Jun 27, 2020 · 5 comments

Comments

@shalvah
Copy link
Collaborator

shalvah commented Jun 27, 2020

Identical to knuckleswtf/pastel-js#1

Our templates are written in Blade, but other than that, it's the same requirement. If a new theme is added to one library, it can easily be ported to the other.

@tsprings
Copy link
Contributor

I would suggest that allowing for custom styles should maybe be on the roadmap before templates.

@shalvah
Copy link
Collaborator Author

shalvah commented Jul 15, 2020

Hmm. I never really thought about custom styles, but yeah, you're right. That would make a lot of people happy, for little cost.

That seems a pretty straightforward implementation: add a css property to the front matter where you can specify files containing your own styles and Pastel turns them into <link> tags and inserts them after its CSS.

@ajcastro
Copy link

ajcastro commented Oct 14, 2020

I dive into the codebase of pastel. I think this the part where we can customize it?
image

Maybe we can add a config file and put there a list of custom css styles paths
config/pastel.php

[
  'css' => [
    get_css_link_tag('highlight-darcula'),
    'path-to-my-custom2.css',
  ]
]

This way we can disable the highlight-darcula, just my idea/suggestion.

Related: knuckleswtf/scribe#113

@seanhudson
Copy link

Is there any progress on CSS styling?

@shalvah
Copy link
Collaborator Author

shalvah commented Jan 12, 2021

No, it's not been a priority. I'm working on Scribe v3, which will likely include that support directly.

@shalvah shalvah removed the good first issue Good for newcomers label Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants