Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Laravel 11 Support #812

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

gabrielrbarbosa
Copy link
Contributor

allow composer packages to versions ^11.0

@gabrielrbarbosa
Copy link
Contributor Author

@shalvah

@codespearhead
Copy link

A stable version of Laravel 11 hasn't been released, has it?

If that's so, I don't think trying to support non-LTS versions of the framework is a good idea.

Also, when the time comes, the tests should be updated in this PR.

@shalvah
Copy link
Contributor

shalvah commented Feb 24, 2024

I'll merge this PR, but it doesn't guarantee the package will correctly work (or even be installable) on Laravel 11.

@shalvah shalvah merged commit 138a47b into knuckleswtf:master Feb 24, 2024
6 checks passed
@gabrielrbarbosa
Copy link
Contributor Author

@shalvah Thanks! Just one conflict still remains:

  • shalvah/clara 3.1.0 requires symfony/console ^4.0|^5.0|^6.0
    and Laravel 11 requires ^7.0, should we update that repository or maybe remove it from composer.json since I didn't find any usage here in code searching for "clara".

@gabrielrbarbosa
Copy link
Contributor Author

shalvah/clara#4

@markwalet
Copy link

I see that this feature was merged to master a few weeks ago. I'm temporarily using dev-master to test my Laravel upgrade and everything looks okay. When can we (roughly) expect a stable release?

@shalvah
Copy link
Contributor

shalvah commented Mar 15, 2024

I've tagged 4.34.0 now (although it's still not tested on L11)

@markwalet
Copy link

Thanks! From my tests the last few days, dev-master worked great on L11 👍

@shalvah
Copy link
Contributor

shalvah commented Mar 17, 2024

Nice!

@cAstraea
Copy link

cAstraea commented Dec 3, 2024

Sorry do you know how to make it pick up routes that now reside in the bootstrap/app.php ? I had to get rid of the routes/api.php file because I wanted my routes prefixed like user/api and not api/user

@markwalet
Copy link

@cAstraea That does not look a Laravel 11 support issue to me. I think it is best to create a new ticket for that.

But AFAIK, Scribe should just pick up any registered routes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants