-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Laravel 11 Support #812
Conversation
A stable version of Laravel 11 hasn't been released, has it? If that's so, I don't think trying to support non-LTS versions of the framework is a good idea. Also, when the time comes, the tests should be updated in this PR. |
I'll merge this PR, but it doesn't guarantee the package will correctly work (or even be installable) on Laravel 11. |
@shalvah Thanks! Just one conflict still remains:
|
I see that this feature was merged to master a few weeks ago. I'm temporarily using |
I've tagged 4.34.0 now (although it's still not tested on L11) |
Thanks! From my tests the last few days, dev-master worked great on L11 👍 |
Nice! |
Sorry do you know how to make it pick up routes that now reside in the bootstrap/app.php ? I had to get rid of the routes/api.php file because I wanted my routes prefixed like user/api and not api/user |
@cAstraea That does not look a Laravel 11 support issue to me. I think it is best to create a new ticket for that. But AFAIK, Scribe should just pick up any registered routes. |
allow composer packages to versions ^11.0