Php 84 upgrade #922
Open
Php 84 upgrade #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll be fine with dropping support for PHP 8.0 and dingo/api; I think we've done a good job of supporting them for a while now. |
|
I'm not familiar with dingo, and the 3 different composer files don't really help with figuring out what is required and what is not. I'm used to using You can find an example here. But I'm not sure if we should fit this into this merge request at all or create a separate issue for that. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev dependencies were a bit outdated. I've updated them where I could without breaking tests, but especially in the lower versions it was unclear to me which versions were still supported.
Besides the dependency upgrades, I've resolved the deprecations warnings for PHP 8.4.