Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new menubar component #260

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Conversation

jer3m01
Copy link
Member

@jer3m01 jer3m01 commented Aug 27, 2023

Based on https://www.radix-ui.com/primitives/docs/components/menubar and follow https://www.w3.org/WAI/ARIA/apg/patterns/menubar/.

  • Extra option boolean than radix for focus on Alt.
  • Test (written but disabled due to jsdom not supporting required events).

Documentation https://deploy-preview-260--kobalte.netlify.app/docs/core/components/menubar

@netlify
Copy link

netlify bot commented Aug 27, 2023

Deploy Preview for kobalte ready!

Name Link
🔨 Latest commit 3c582f1
🔍 Latest deploy log https://app.netlify.com/sites/kobalte/deploys/654182b34caf2b0008d40417
😎 Deploy Preview https://deploy-preview-260--kobalte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jer3m01 jer3m01 mentioned this pull request Aug 27, 2023
@jer3m01 jer3m01 marked this pull request as ready for review October 31, 2023 22:07
@fabien-ml fabien-ml changed the base branch from main to develop November 3, 2023 21:23
@fabien-ml fabien-ml merged commit 8e187e9 into kobaltedev:develop Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants